Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-collapse): add new prop `appear` to animate an initially visible collapse #4317

merged 41 commits into from Nov 15, 2019


Copy link

tmorehouse commented Oct 30, 2019

Describe the PR

Adds new prop appear, which when set to true will animate the collapse if initially visible on mount.

Creates utility helper functional component BVCollapse which can be shared amongst other components (i.e. table details slot, dropdown menu) in the future.

Target release: v2.2.0

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

This comment has been minimized.

Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #4317 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4317      +/-   ##
+ Coverage   99.91%   99.91%   +<.01%     
  Files         238      239       +1     
  Lines        4607     4617      +10     
  Branches     1298     1298              
+ Hits         4603     4613      +10     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/utils/bv-collapse.js 100% <100%> (ø)
src/components/collapse/collapse.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ab261...e3955ac. Read the comment docs.

@tmorehouse tmorehouse added this to In progress in 2.1.0 via automation Oct 30, 2019
tmorehouse added 9 commits Oct 30, 2019
@tmorehouse tmorehouse marked this pull request as ready for review Oct 30, 2019
tmorehouse added 13 commits Oct 30, 2019
@tmorehouse tmorehouse added this to Features in Roadmap Nov 12, 2019
@jackmu95 jackmu95 added this to In progress in 2.2.0 via automation Nov 13, 2019
@jackmu95 jackmu95 removed this from Features in Roadmap Nov 13, 2019
jackmu95 added 5 commits Nov 13, 2019
@jackmu95 jackmu95 self-requested a review Nov 13, 2019
tmorehouse added 7 commits Nov 13, 2019
@tmorehouse tmorehouse removed the Status: WIP label Nov 13, 2019
@tmorehouse tmorehouse requested a review from jackmu95 Nov 13, 2019
jackmu95 added 2 commits Nov 14, 2019
@jackmu95 jackmu95 merged commit 136a72b into dev Nov 15, 2019
9 checks passed
9 checks passed
License Compliance All checks passed.
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch 100% of diff hit (target 99.91%)
codecov/project 99.91% (+<.01%) compared to 84ab261
deploy/netlify Deploy preview ready!
security/snyk - package.json (pi0) No manifest changes detected
2.2.0 automation moved this from In progress to Done Nov 15, 2019
@jackmu95 jackmu95 deleted the feat/collapse-appear branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.