Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(b-tabs): allow space to trigger tab activation when `no-key-nav` is enabled (fixes #4323) #4326
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Oct 30, 2019
•
Codecov Report
@@ Coverage Diff @@
## dev #4326 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 238 238
Lines 4576 4576
Branches 1284 1284
=======================================
Hits 4572 4572
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
731365b
into
dev
9 checks passed
9 checks passed
security/snyk - package.json (pi0)
No manifest changes detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tmorehouse commentedOct 30, 2019
•
edited
Describe the PR
Fixes #4323
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: