Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-img, b-img-lazy): add support for `srcset` and `sizes` props (closes #4348) #4350

Merged
merged 15 commits into from Nov 8, 2019

Conversation

@tmorehouse
Copy link
Member

tmorehouse commented Nov 6, 2019

Describe the PR

Add new optional props srcset and sizes (not supported on IE 11 though)

Props will either accept a string or array of strings

For b-img-lazy, the values of srcset and sizes will only be applied when the image is in view. src is still required for fallback image.

Closes #4348

Caveat: vue-loader does not support the processing of srcset (multiple URLs), so project relative URLs must be required, but one has to be cautious of images being converted to data URIs as one can exceed the maximum supported attribute value length.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@tmorehouse tmorehouse added this to In progress in 2.1.0 via automation Nov 6, 2019
@tmorehouse tmorehouse changed the title feat(b-img-lazy): add support for `srcset` and `sizes` props feat(b-img-lazy): add support for `srcset` and `sizes` props (closes #4348) Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #4350 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4350      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files         238      238              
  Lines        4577     4585       +8     
  Branches     1284     1286       +2     
==========================================
+ Hits         4573     4581       +8     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/image/img-lazy.js 100% <100%> (ø) ⬆️
src/components/image/img.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7087f0...e656ab8. Read the comment docs.

@tmorehouse tmorehouse changed the title feat(b-img-lazy): add support for `srcset` and `sizes` props (closes #4348) feat(b-img, b-img-lazy): add support for `srcset` and `sizes` props (closes #4348) Nov 6, 2019
tmorehouse added 6 commits Nov 6, 2019
@tmorehouse tmorehouse removed the Status: WIP label Nov 6, 2019
@tmorehouse tmorehouse requested a review from jackmu95 Nov 6, 2019
@tmorehouse tmorehouse marked this pull request as ready for review Nov 6, 2019
tmorehouse and others added 3 commits Nov 6, 2019
jackmu95 and others added 2 commits Nov 8, 2019
@tmorehouse tmorehouse merged commit f419cb4 into dev Nov 8, 2019
9 checks passed
9 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.91%)
Details
codecov/project 99.91% (+<.01%) compared to f7087f0
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
2.1.0 automation moved this from In progress to Done Nov 8, 2019
@tmorehouse tmorehouse deleted the issue/4348 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.1.0
  
Done
2 participants
You can’t perform that action at this time.