New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-img, b-img-lazy): add support for srcset
and sizes
props (closes #4348)
#4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srcset
and sizes
propssrcset
and sizes
props (closes #4348)
Codecov Report
@@ Coverage Diff @@
## dev #4350 +/- ##
==========================================
+ Coverage 99.91% 99.91% +<.01%
==========================================
Files 238 238
Lines 4577 4585 +8
Branches 1284 1286 +2
==========================================
+ Hits 4573 4581 +8
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
srcset
and sizes
props (closes #4348)srcset
and sizes
props (closes #4348)
jacobmllr95
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Describe the PR
Add new optional props
srcset
andsizes
(not supported on IE 11 though)Props will either accept a string or array of strings
For
b-img-lazy
, the values ofsrcset
andsizes
will only be applied when the image is in view.src
is still required for fallback image.Closes #4348
Caveat: vue-loader does not support the processing of
srcset
(multiple URLs), so project relative URLs must berequired
, but one has to be cautious of images being converted to data URIs as one can exceed the maximum supported attribute value length.PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: