New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-table, b-table-lite): handle edge case with row events when table is removed from dom. instantiate row event handlers only when listeners are registered (fixes #4384) #4388
Conversation
…le is removed from dom (fixes #4384)
Codecov Report
@@ Coverage Diff @@
## dev #4388 +/- ##
==========================================
+ Coverage 99.91% 99.91% +<.01%
==========================================
Files 239 239
Lines 4617 4624 +7
Branches 1298 1300 +2
==========================================
+ Hits 4613 4620 +7
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
It appears that event listeners that are programatically added via Created an upstream issue at vuejs/vue#10825 |
Describe the PR
Fix issue with row-hovered/unhovered events where table is removed from DOM before the event processing gets a chance to finish.
PR also only emits row events if listeners are registered, reducing processing time for events that don't have listeners registered.
Fixes #4384
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: