Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-dropdown): add splitClass property to dropdown component #4394

Merged

Conversation

@enriquecastl
Copy link
Contributor

enriquecastl commented Nov 17, 2019

Describe the PR

Adds a splitClass property to the dropdown component to allow setting a custom class selector to the dropdown split button when split mode is enabled.

Why is this necessary?

We need to customize the dropdown’s split and toggle buttons based on our design system specifications. We apply these customizations by adding a custom class selector using the toggleClass property for the toggle button. We also want to apply a class selector to the split button, but the dropdown component don’t expose a property to achieve that.

We are using a workaround of applying these classes when the component is updated, but we’d like to replace it with a sound approach.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #4394 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4394   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         240      240           
  Lines        4622     4622           
  Branches     1303     1303           
=======================================
  Hits         4618     4618           
  Misses          3        3           
  Partials        1        1
Impacted Files Coverage Δ
src/components/dropdown/dropdown.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa25f6...c71a8cc. Read the comment docs.

@tmorehouse tmorehouse self-requested a review Nov 18, 2019
@jackmu95 jackmu95 self-requested a review Nov 18, 2019
@jackmu95 jackmu95 added this to In progress in 2.2.0 via automation Nov 18, 2019
@jackmu95 jackmu95 merged commit a5f342e into bootstrap-vue:dev Nov 18, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1fa25f6...c71a8cc
Details
codecov/project 99.91% remains the same compared to 1fa25f6
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
2.2.0 automation moved this from In progress to Done Nov 18, 2019
@jackmu95

This comment has been minimized.

Copy link
Member

jackmu95 commented Nov 18, 2019

Thanks @enriquecastl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.2.0
  
Done
3 participants
You can’t perform that action at this time.