New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-form-tags): new tagged input component #4409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #4409 +/- ##
==========================================
+ Coverage 99.91% 99.91% +<.01%
==========================================
Files 242 245 +3
Lines 4673 4818 +145
Branches 1310 1345 +35
==========================================
+ Hits 4669 4814 +145
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
jacobmllr95
approved these changes
Nov 28, 2019
This was referenced Jan 17, 2020
This was referenced Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Describe the PR
New form control component
<b-form-tags>
(and helper component<b-form-tag>
)Has default rendering of layout which can be overridden via the scoped default slot.
To Do:
;
or,
, is pressed)tag-state
event when tags are added (or can't be added)change
event opt-in<select>
aria-live="polite"
with non-atomic updates (additions and removals announced only)Future Ideas:
is-invalid
class to root element on form submission (and callevt.preventDefault()
on the form's submit eventLoosely based on https://adamwathan.me/renderless-components-in-vuejs/
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: