Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-row): add Bootstrap v4.4 row columns support #4439

Merged
merged 17 commits into from Dec 2, 2019
Merged

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Nov 29, 2019

Describe the PR

Adds support for Bootstrap v4.4 row columns on b-row, via new props cols, cols-sm, cols-md, etc.

https://getbootstrap.com/docs/4.4/layout/grid/#row-columns

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added this to In progress in 2.2.0 via automation Nov 29, 2019
@codecov
Copy link

@codecov codecov bot commented Nov 29, 2019

Codecov Report

Merging #4439 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4439      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files         242      242              
  Lines        4652     4673      +21     
  Branches     1308     1310       +2     
==========================================
+ Hits         4648     4669      +21     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/layout/col.js 100% <100%> (ø) ⬆️
src/components/layout/row.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1c10e...0620c97. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 Nov 29, 2019
@jacobmllr95 jacobmllr95 added the Bootstrap v4 label Nov 29, 2019
@jacobmllr95 jacobmllr95 merged commit 833b028 into dev Dec 2, 2019
9 checks passed
2.2.0 automation moved this from In progress to Done Dec 2, 2019
@jacobmllr95 jacobmllr95 deleted the feat/row-columns branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants