Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-dropdown-form): add formClass prop for adding classes to the form element (closes #4474) #4475

Merged
merged 3 commits into from Dec 9, 2019

Conversation

@bbugh
Copy link
Contributor

bbugh commented Dec 9, 2019

Describe the PR

We use b-dropdown-form in a bunch of places (mostly advanced search filters), and want to have control over the form class[es]. It's less complex and more reusable to specifically list the form classes in the parent component, rather than specifying prop options for layout and/or using multiple css selectors. Currently, passing a class prop on b-dropdown-form sets the class on the li.

Closes #4474

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@bbugh bbugh changed the title feat(b-dropdown-form): add formClass prop for adding classes to the form element (fixes #4474) feat(b-dropdown-form): add formClass prop for adding classes to the form element (closes #4474) Dec 9, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #4475 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4475   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         247      247           
  Lines        4850     4850           
  Branches     1359     1359           
=======================================
  Hits         4846     4846           
  Misses          3        3           
  Partials        1        1
Impacted Files Coverage Δ
src/components/dropdown/dropdown-form.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e216f6...5a79988. Read the comment docs.

@jackmu95 jackmu95 requested review from tmorehouse and jackmu95 Dec 9, 2019
@jackmu95 jackmu95 added this to In progress in 2.2.0 via automation Dec 9, 2019
@tmorehouse tmorehouse merged commit eef4200 into bootstrap-vue:dev Dec 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 5e216f6...5a79988
Details
codecov/project 99.91% remains the same compared to 5e216f6
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
2.2.0 automation moved this from In progress to Done Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.2.0
  
Done
3 participants
You can’t perform that action at this time.