Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): handle undocumented breaking changes in babel-standalone for IE11 #4484

merged 33 commits into from Dec 13, 2019


Copy link

tmorehouse commented Dec 10, 2019

Describe the PR

Fixes the playground and live examples which broke in IE11 due to breaking change in babel-standalone introduced via PR babel/babel#10420 (related issue babel/babel#10074)

This PR adds in on-demand polyfills for String.prototype.trimStart/End/Left/Right when the transpiler is loaded (only in browsers that need transpiling)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

This comment has been minimized.

Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #4484 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4484   +/-   ##
  Coverage   99.91%   99.91%           
  Files         247      247           
  Lines        4855     4855           
  Branches     1366     1366           
  Hits         4851     4851           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b246682...5f05a42. Read the comment docs.

tmorehouse added 21 commits Dec 10, 2019
@tmorehouse tmorehouse changed the title chore(docs): add gated flag to request fix(docs): handle breaking changes in babel-standalone for IE11 Dec 11, 2019
@tmorehouse tmorehouse added this to In progress in 2.2.0 via automation Dec 11, 2019
@tmorehouse tmorehouse changed the title fix(docs): handle breaking changes in babel-standalone for IE11 fix(docs): handle undocumented breaking changes in babel-standalone for IE11 Dec 11, 2019
tmorehouse added 4 commits Dec 11, 2019
@tmorehouse tmorehouse removed the Status: WIP label Dec 11, 2019
@tmorehouse tmorehouse marked this pull request as ready for review Dec 11, 2019
@jackmu95 jackmu95 self-requested a review Dec 12, 2019
tmorehouse and others added 5 commits Dec 12, 2019
@jackmu95 jackmu95 merged commit 56f8bb5 into dev Dec 13, 2019
7 of 8 checks passed
7 of 8 checks passed
License Compliance FOSSA is analyzing this commit
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch Coverage not affected when comparing b246682...5f05a42
codecov/project 99.91% remains the same compared to b246682
security/snyk - package.json (pi0) No manifest changes detected
2.2.0 automation moved this from In progress to Done Dec 13, 2019
@jackmu95 jackmu95 deleted the docs/polyfill branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.