Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): configure pre-commit hook (fixes #4532) #4552

Merged
merged 6 commits into from Jan 7, 2020

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Jan 3, 2020

Describe the PR

closes #4532

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch

  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)

  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.

  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

  • Includes documentation updates (including updating the component's package.json for slot and event changes)

  • Includes any needed TypeScript declaration file updates

  • New/updated tests are included and passing (if required)

  • Existing test suites are passing

  • CodeCov for patch has met target

  • The changes have not impacted the functionality of other components or directives

  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #4552 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4552   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         251      251           
  Lines        5218     5218           
  Branches     1380     1380           
=======================================
  Hits         5214     5214           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc801a7...b41c9c0. Read the comment docs.

@jacobmllr95 jacobmllr95 added PR: Patch Requires patch version bump Type: Feature labels Jan 3, 2020
@jacobmllr95 jacobmllr95 added this to In progress in 2.2.0 via automation Jan 3, 2020
@jacobmllr95 jacobmllr95 merged commit 1bf9e59 into bootstrap-vue:dev Jan 7, 2020
2.2.0 automation moved this from In progress to Done Jan 7, 2020
@jacobmllr95
Copy link
Member

jacobmllr95 commented Jan 7, 2020

Thanks @jamesgeorge007!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Enhancement
Projects
No open projects
2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

[chore]: configure pre-commit hook for better DX
2 participants