Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-tooltip): add `noninteractive` prop (closes #4556) #4563

Merged
merged 13 commits into from Jan 8, 2020

Conversation

@jackmu95
Copy link
Member

jackmu95 commented Jan 7, 2020

Describe the PR

This PR adds a noninteractive prop to the <b-tooltip> component and noninteractive modifier to the v-b-tooltip directive. By setting the prop/modifier you can restore Bootstraps default behavior when hovering over the tooltips content.

Closes #4556.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@jackmu95 jackmu95 requested a review from tmorehouse Jan 7, 2020
@jackmu95 jackmu95 added this to In progress in 2.2.0 via automation Jan 7, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #4563 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4563      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         251      251              
  Lines        5218     5219       +1     
  Branches     1380     1380              
==========================================
+ Hits         5214     5215       +1     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/tooltip/tooltip.js 100% <ø> (ø) ⬆️
.../components/tooltip/helpers/bv-tooltip-template.js 100% <ø> (ø) ⬆️
src/components/tooltip/helpers/bv-tooltip.js 99.6% <100%> (ø) ⬆️
src/directives/tooltip/tooltip.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a2fba...7d17c1e. Read the comment docs.

jackmu95 added 3 commits Jan 7, 2020
@tmorehouse

This comment has been minimized.

Copy link
Member

tmorehouse commented Jan 7, 2020

This could be seen as a breaking change, as it is a change in behaviour for BootsrapVue which has been in place for quite some time.

The no-hide on hover was was added for Popovers (and tooltips), and for Accessibility reasons (uses that may have issues holding a mouse steady).

Also note that IE 11 does not support pointer-events: none;

@tmorehouse

This comment has been minimized.

Copy link
Member

tmorehouse commented Jan 7, 2020

It might be better to make this new (to BootstrapVue) behaviour opt-in (i.e. a no-interactive or noninteractive)

@jackmu95

This comment has been minimized.

Copy link
Member Author

jackmu95 commented Jan 7, 2020

@tmorehouse Solid points. A noninteractive modifier seems to be a good solution.

@tmorehouse

This comment has been minimized.

Copy link
Member

tmorehouse commented Jan 7, 2020

It should also be noted that it only affects (applies to) the hover trigger.

@tmorehouse

This comment has been minimized.

Copy link
Member

tmorehouse commented Jan 7, 2020

Perhaps we should also target this feature to release 2.3.0

@jackmu95 jackmu95 removed this from In progress in 2.2.0 Jan 7, 2020
@jackmu95 jackmu95 added this to In progress in 2.3.0 via automation Jan 7, 2020
@jackmu95 jackmu95 changed the title feat(b-tooltip): add `interactive` prop (closes #4556) feat(b-tooltip): add `noninteractive` prop (closes #4556) Jan 7, 2020
tmorehouse and others added 6 commits Jan 7, 2020
@jackmu95 jackmu95 removed this from In progress in 2.3.0 Jan 7, 2020
@jackmu95 jackmu95 added this to In progress in 2.2.0 via automation Jan 7, 2020
@jackmu95 jackmu95 requested a review from tmorehouse Jan 7, 2020
@jackmu95 jackmu95 merged commit b3ad726 into dev Jan 8, 2020
9 checks passed
9 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.92%)
Details
codecov/project 99.92% (+<.01%) compared to f5a2fba
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
2.2.0 automation moved this from In progress to Done Jan 8, 2020
@jackmu95 jackmu95 deleted the feat-tooltip-interactive-prop branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.2.0
  
Done
2 participants
You can’t perform that action at this time.