-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-button-close): add content
prop (closes #4527)
#4574
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4574 +/- ##
==========================================
- Coverage 99.92% 99.92% -0.01%
==========================================
Files 251 251
Lines 5225 5220 -5
Branches 1384 1384
==========================================
- Hits 5221 5216 -5
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
One thing to note is that we used to have SSR mismatch errors when using When using HTML entities that maps to UTF8 characters, the browser would convert the inner HTML/text to the UTF8 character, and the rehydration process would complain that |
@tmorehouse I currently don't see any SSR mismatch errors. |
@jackmu95 OK cool... Vue must have fixed the issue with the rehydration process. |
I might add in an option for passing vNode Array via the message box methods for the button content (via a separate PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We target this for the v2.3.0 release (after any v2.2.1 release)
Describe the PR
This PR adds a
content
prop to the<b-button-close>
component.It also adds the prop to the
BButtonClose
settings to make it globally configurable.A
headerCloseContent
property is also added to the<b-modal>
component and theBModal
settings to be able to change the close button content by modal or for all modals globally.Closes #4527.
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: