Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal, tooltips, popovers): remove no longer needed `nextTick` delay when updating content in transporter portal (closes #4589) #4604

Merged
merged 17 commits into from Jan 13, 2020

Conversation

@tmorehouse
Copy link
Member

tmorehouse commented Jan 11, 2020

Describe the PR

Removes the nextTick() delay when updating the transporter portal target content.

Since all slots are now considered to be scoped slot functions, the nextTick delay is not needed to get the children v-nodes.

portal-target has removed their nextTick delay in the updated hook (although vue-simple-portal still has the delay in its updated hook).

We should be able to remove some of the await nextTick statements in unit tests for modal, tooltips and popovers, although it is still required when testing transitions

Closes #4589

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #4604 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4604   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         251      251           
  Lines        5223     5223           
  Branches     1384     1384           
=======================================
  Hits         5219     5219           
  Misses          3        3           
  Partials        1        1
Impacted Files Coverage Δ
src/utils/transporter.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f9c5a...74ddd2f. Read the comment docs.

@tmorehouse tmorehouse changed the title chore: remove nextTick delay in BootstrapVue transporter portal fix: remove no longer needed nextTick delay in transporter portal (modal, tooltips and popovers) Jan 11, 2020
@tmorehouse tmorehouse changed the title fix: remove no longer needed nextTick delay in transporter portal (modal, tooltips and popovers) fix(modal, tooltips, popovers): remove no longer needed `nextTick` delay when updating content in transporter portal (closes #4589) Jan 11, 2020
tmorehouse and others added 13 commits Jan 11, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Jan 12, 2020
@tmorehouse tmorehouse removed the Status: WIP label Jan 12, 2020
@tmorehouse tmorehouse requested a review from jackmu95 Jan 12, 2020
jackmu95 added 2 commits Jan 13, 2020
@jackmu95 jackmu95 merged commit 0e3e7e0 into dev Jan 13, 2020
5 of 7 checks passed
5 of 7 checks passed
License Compliance FOSSA is analyzing this commit
Details
deploy/netlify Deploy preview processing.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
security/snyk - package.json (pi0) No manifest changes detected
@jackmu95 jackmu95 deleted the transporter-delay branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.