Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): make icon transform props work with IE11 (closes #4607) #4608

Merged
merged 14 commits into from Jan 12, 2020

Conversation

@tmorehouse
Copy link
Member

tmorehouse commented Jan 12, 2020

Describe the PR

Switch from CSS transforms to SVG transform attribute to make <b-icon*> props scale, flip-h, flip-v, rotate, shift-h, and shift-v work with IE11.

Closes #4607

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #4608 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4608      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         251      251              
  Lines        5219     5224       +5     
  Branches     1380     1384       +4     
==========================================
+ Hits         5215     5220       +5     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/icons/helpers/make-icon.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update defbec0...ca9324f. Read the comment docs.

tmorehouse added 5 commits Jan 12, 2020
tmorehouse added 3 commits Jan 12, 2020
@tmorehouse tmorehouse removed the Status: WIP label Jan 12, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Jan 12, 2020
@tmorehouse tmorehouse requested a review from jackmu95 Jan 12, 2020
tmorehouse added 2 commits Jan 12, 2020
@tmorehouse tmorehouse changed the title fix(icons): make icon transforms work with IE11 (closes #4607) fix(icons): make icon transform props work with IE11 (closes #4607) Jan 12, 2020
@tmorehouse tmorehouse merged commit 899779f into dev Jan 12, 2020
9 checks passed
9 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.92%)
Details
codecov/project 99.92% (+<.01%) compared to defbec0
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
@tmorehouse tmorehouse deleted the issue/4607 branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.