-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-pagination, b-pagination-nav): add page button class props and option to show first/last page numbers (closes #4597, #4533) #4622
feat(b-pagination, b-pagination-nav): add page button class props and option to show first/last page numbers (closes #4597, #4533) #4622
Conversation
…rst/last page numbers
Codecov Report
@@ Coverage Diff @@
## dev #4622 +/- ##
==========================================
+ Coverage 99.92% 99.92% +<.01%
==========================================
Files 253 253
Lines 5230 5259 +29
Branches 1388 1399 +11
==========================================
+ Hits 5226 5255 +29
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
I think we might need a bit more conditional code in the render function, as the Otherwise, good first stab at this. Perhaps, do not render the "go to first page" button at all, and only render the extra page Or, we filter out the regular page |
I definitely like the visual rendering look of it. |
We'll also need to add an example (or at least some verbiage) in both pagination and pagination-nav docs |
Describe the PR
This PR add adds following new props to the
<b-pagination>
and<b-pagination-nav>
components:first-class
- Adds a custom class to the first page button.prev-class
- Adds a custom class to the previous page button.next-class
- Adds a custom class to the next page button.last-class
- Adds a custom class to the last page button.page-class
- Adds a custom class to the page buttons.ellipsis-class
- Adds a custom class to the ellipsis elements.first-number
- Show the first page number in favor of thefirst-text
. Will move the first page button after the previous page button.last-number
- Show the last page number in favor of thelast-text
. Will move the last page button before the next page button.Closes #4597, Closes #4533.
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: