Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-form-tags): new option to specify input type (closes #4644) #4645

Merged
merged 17 commits into from Jan 22, 2020
Merged

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jan 17, 2020

Describe the PR

Ads a new prop input-type to allow user to specify type of input to use in default render:

  • text (default)
  • email
  • url
  • tel
  • number

Closes #4644

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added this to In progress in 2.3.0 via automation Jan 17, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 17, 2020

Codecov Report

Merging #4645 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4645   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         251      251           
  Lines        5223     5223           
  Branches     1385     1385           
=======================================
  Hits         5219     5219           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 208922c...958b0b0. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review Jan 19, 2020
@tmorehouse tmorehouse added the PR: Minor label Jan 19, 2020
@jacobmllr95 jacobmllr95 self-requested a review Jan 22, 2020
@tmorehouse tmorehouse merged commit b899fac into dev Jan 22, 2020
8 of 9 checks passed
2.3.0 automation moved this from In progress to Done Jan 22, 2020
@tmorehouse tmorehouse deleted the feat/4644 branch Jan 22, 2020
@tmorehouse tmorehouse changed the title feat(form-tags): new option to specify input type (closes #4644) feat(b-form-tags): new option to specify input type (closes #4644) Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Minor Type: Enhancement
Projects
No open projects
2.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

2 participants