Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): pass all Array/Object util shortcuts as functions, for handling late loaded polyfills #4647

Merged
merged 11 commits into from Jan 21, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jan 18, 2020

Describe the PR

By making each static shortcut a method, it allows for handling of late loaded polyfills, while still allowing for better minification of code.

See #3641 (comment)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) refactor

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

My making each shortcut a method, it allows for handling of late loaded polyfills.

See #3641 (comment)
@tmorehouse tmorehouse added Status: WIP PR: Patch labels Jan 18, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 18, 2020

Codecov Report

Merging #4647 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4647   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         251      251           
  Lines        5218     5218           
  Branches     1384     1384           
=======================================
  Hits         5214     5214           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f8b0c...bb08484. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 Jan 18, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Jan 18, 2020
@tmorehouse tmorehouse changed the title chore(utils): pass all Array/Object shortcuts as functions fix(utils): pass all Array/Object shortcuts as functions, for handling late loaded polyfills Jan 20, 2020
@tmorehouse tmorehouse changed the title fix(utils): pass all Array/Object shortcuts as functions, for handling late loaded polyfills fix(utils): pass all Array/Object util shortcuts as functions, for handling late loaded polyfills Jan 20, 2020
@jacobmllr95 jacobmllr95 merged commit f584425 into dev Jan 21, 2020
9 checks passed
@jacobmllr95 jacobmllr95 deleted the chore-utils branch Jan 21, 2020
@jacobmllr95 jacobmllr95 added this to In progress in 2.3.0 via automation Jan 22, 2020
@jacobmllr95 jacobmllr95 moved this from In progress to Done in 2.3.0 Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants