Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-form-input, b-form-textarea): properly handle out-of-sync values (closes #4695) #4701



Copy link

@jacobmllr95 jacobmllr95 commented Jan 30, 2020

Describe the PR

This PR brings back the changes from #3172 in a better way.
They were accidentally removed in #4169.

Closes #4695.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 added Type: Fix PR: Patch labels Jan 30, 2020
@jacobmllr95 jacobmllr95 requested a review from tmorehouse Jan 30, 2020
@jacobmllr95 jacobmllr95 added this to In progress in 2.4.0 via automation Jan 30, 2020
Copy link

@codecov codecov bot commented Jan 30, 2020

Codecov Report

Merging #4701 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4701      +/-   ##
+ Coverage   99.92%   99.92%   +<.01%     
  Files         253      253              
  Lines        5263     5266       +3     
  Branches     1397     1399       +2     
+ Hits         5259     5262       +3     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/mixins/form-text.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedf702...ee7ac7e. Read the comment docs.

Copy link

@tmorehouse tmorehouse commented Jan 30, 2020

If you try the example of allowing only digits, and set lazy-formatter to true, it appears that the lazy formatting is broken.... but that is because the user should also be setting the g flag on the regular expression: value.replace(/[^\d]/g, '')

@tmorehouse tmorehouse changed the title fix(form-input/form-textarea): properly handle out-of-sync values (closes #4695) fix(b-form-input/b-form-textarea): properly handle out-of-sync values (closes #4695) Jan 30, 2020
@tmorehouse tmorehouse changed the title fix(b-form-input/b-form-textarea): properly handle out-of-sync values (closes #4695) fix(b-form-input, b-form-textarea): properly handle out-of-sync values (closes #4695) Jan 30, 2020
@jacobmllr95 jacobmllr95 merged commit 954176d into dev Jan 30, 2020
9 checks passed
2.4.0 automation moved this from In progress to Done Jan 30, 2020
@jacobmllr95 jacobmllr95 deleted the fix-form-input-form-textarea-formatter-value-out-of-sync branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
PR: Patch Type: Fix
No open projects

Successfully merging this pull request may close these issues.

2 participants