Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-calendar, b-form-datepicker): new components b-calendar and b-form-datepicker (closes #3676, #1428) #4712

Merged
merged 604 commits into from Feb 16, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 1, 2020

Describe the PR

New components:

  • <b-calendar> calendar widget component
  • <b-form-datepicker> date picker form input component (based on <b-calendar> and <b-dropdown>)

Calendar supports internationalization via Intl.DateTimeFormat, but requires aria labels to be manually internationalized.

Components are WAI-ARIA compliant. Both components are minimalistic by design for ARIA simplicity (i.e. no date range selection).

<b-calendar> and <b-form-datepicker> require minor custom CSS.

BCalendar:

https://deploy-preview-4712--bootstrap-vue.netlify.com/docs/components/calendar/

image

BFormDatepicker (collapsed state):

https://deploy-preview-4712--bootstrap-vue.netlify.com/docs/components/form-datepicker/

image

Closes #3676
Closes #1428

Screen reader tests manually performed with ChromeVox and NVDA

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

@codecov codecov bot commented Feb 1, 2020

Codecov Report

Merging #4712 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4712      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         256      261       +5     
  Lines        5292     5679     +387     
  Branches     1405     1480      +75     
==========================================
+ Hits         5288     5675     +387     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/index.js 100% <ø> (ø) ⬆️
src/index.js 100% <ø> (ø) ⬆️
src/components/modal/modal.js 99.59% <ø> (ø) ⬆️
src/components/table/helpers/filter-event.js 100% <ø> (ø) ⬆️
src/mixins/dropdown.js 100% <100%> (ø) ⬆️
src/components/dropdown/dropdown.js 100% <100%> (ø) ⬆️
src/components/calendar/index.js 100% <100%> (ø)
src/components/form-datepicker/index.js 100% <100%> (ø)
src/components/nav/nav-item-dropdown.js 100% <100%> (ø) ⬆️
src/components/calendar/calendar.js 100% <100%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7adc6d...eed5620. Read the comment docs.

@tmorehouse tmorehouse added this to In progress in 2.4.2 via automation Feb 1, 2020
@tmorehouse tmorehouse changed the title feat(b-calendar, b-form-date): new components b-calendar and b-form-date feat(b-calendar, b-form-date): new components b-calendar and b-form-date (closes #3676) Feb 1, 2020
@tmorehouse tmorehouse changed the title feat(b-calendar, b-form-date): new components b-calendar and b-form-date (closes #3676) feat(b-calendar, b-form-date): new components b-calendar and b-form-date (closes #3676, #1428) Feb 1, 2020
@epileftro85
Copy link

@epileftro85 epileftro85 commented Feb 1, 2020

Finally, these are great news, @tmorehouse thanks for the awesome work

@tmorehouse
Copy link
Member Author

@tmorehouse tmorehouse commented Feb 3, 2020

While working on the b-date-datepicker component validation states, I discovered a bug in Bootstrap v4.4 CSS regarding input-group sizing and form-control validation states: twbs/bootstrap#30131

@jacobmllr95 jacobmllr95 self-requested a review Feb 4, 2020
@tmorehouse tmorehouse changed the title feat(b-calendar, b-form-date): new components b-calendar and b-form-date (closes #3676, #1428) feat(b-calendar, b-form-date): new components b-calendar and b-form-datepicker (closes #3676, #1428) Feb 15, 2020
@tmorehouse tmorehouse changed the title feat(b-calendar, b-form-date): new components b-calendar and b-form-datepicker (closes #3676, #1428) feat(b-calendar, b-form-datepicker): new components b-calendar and b-form-datepicker (closes #3676, #1428) Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.5.0
  
Done
Development

Successfully merging this pull request may close these issues.

4 participants