New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-calendar, b-form-datepicker): new components b-calendar
and b-form-datepicker
(closes #3676, #1428)
#4712
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4712 +/- ##
==========================================
+ Coverage 99.92% 99.92% +<.01%
==========================================
Files 256 261 +5
Lines 5292 5679 +387
Branches 1405 1480 +75
==========================================
+ Hits 5288 5675 +387
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
b-calendar
and b-form-date
b-calendar
and b-form-date
(closes #3676)
b-calendar
and b-form-date
(closes #3676)b-calendar
and b-form-date
(closes #3676, #1428)
Finally, these are great news, @tmorehouse thanks for the awesome work |
While working on the |
b-calendar
and b-form-date
(closes #3676, #1428)b-calendar
and b-form-datepicker
(closes #3676, #1428)
b-calendar
and b-form-datepicker
(closes #3676, #1428)b-calendar
and b-form-datepicker
(closes #3676, #1428)
Describe the PR
New components:
<b-calendar>
calendar widget component<b-form-datepicker>
date picker form input component (based on<b-calendar>
and<b-dropdown>
)Calendar supports internationalization via
Intl.DateTimeFormat
, but requires aria labels to be manually internationalized.Components are WAI-ARIA compliant. Both components are minimalistic by design for ARIA simplicity (i.e. no date range selection).
<b-calendar>
and<b-form-datepicker>
require minor custom CSS.BCalendar:
https://deploy-preview-4712--bootstrap-vue.netlify.com/docs/components/calendar/
BFormDatepicker (collapsed state):
https://deploy-preview-4712--bootstrap-vue.netlify.com/docs/components/form-datepicker/
Closes #3676
Closes #1428
Screen reader tests manually performed with ChromeVox and NVDA
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: