Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-form-input, b-form-textarea): handle change event for all mobile device keyboards (closes #4724) #4739

Merged
merged 7 commits into from Feb 8, 2020

Conversation

@tmorehouse
Copy link
Member

tmorehouse commented Feb 7, 2020

Describe the PR

Stops ignoring change events if evt.taget.composing flag is still set by Vue.

Also adds notes to docs about mobile browser keyboard predictive text handling and IME composition handling.

Closes #4724

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
…tive text on mobile (fixes #4724)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #4739 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4739   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         253      253           
  Lines        5268     5268           
  Branches     1398     1398           
=======================================
  Hits         5264     5264           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe8f41...68ad46a. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(b-form-input, b-form-textarea): handle value change due to predictive text on mobile (fixes #4724) fix(b-form-input, b-form-textarea): handle value change due to predictive text on some mobile devices (fixes #4724) Feb 7, 2020
@tmorehouse tmorehouse added this to In progress in 2.4.1 via automation Feb 7, 2020
tmorehouse added 2 commits Feb 7, 2020
@tmorehouse tmorehouse changed the title fix(b-form-input, b-form-textarea): handle value change due to predictive text on some mobile devices (fixes #4724) fix(b-form-input, b-form-textarea): handle change event to predictive text on some mobile devices (closes #4724) Feb 7, 2020
@tmorehouse tmorehouse requested a review from jackmu95 Feb 7, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Feb 7, 2020
@tmorehouse tmorehouse added Type: Docs and removed Status: WIP labels Feb 7, 2020
@tmorehouse tmorehouse changed the title fix(b-form-input, b-form-textarea): handle change event to predictive text on some mobile devices (closes #4724) fix(b-form-input, b-form-textarea): handle change event for all mobile device keyboards (closes #4724) Feb 7, 2020
tmorehouse added 2 commits Feb 8, 2020
@tmorehouse tmorehouse merged commit 166a932 into dev Feb 8, 2020
8 of 9 checks passed
8 of 9 checks passed
License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7fe8f41...68ad46a
Details
codecov/project 99.92% remains the same compared to 7fe8f41
Details
netlify/bootstrap-vue/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected
2.4.1 automation moved this from In progress to Done Feb 8, 2020
@tmorehouse tmorehouse deleted the issue/4724 branch Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.4.1
  
Done
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.