Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-modal): transition timing (closes #4761) #4766

Merged
merged 1 commit into from Feb 14, 2020
Merged

fix(b-modal): transition timing (closes #4761) #4766

merged 1 commit into from Feb 14, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 14, 2020

Describe the PR

Minor adjustments to the modal show enter transition timing

Closes #4761

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

@codecov codecov bot commented Feb 14, 2020

Codecov Report

Merging #4766 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4766      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         255      255              
  Lines        5276     5277       +1     
  Branches     1401     1401              
==========================================
+ Hits         5272     5273       +1     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/modal/modal.js 99.59% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adcd0f...85fd6a9. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(b-modal): transition timing fix(b-modal): transition timing (closes #4761) Feb 14, 2020
@tmorehouse tmorehouse added PR: Patch Type: Fix labels Feb 14, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Feb 14, 2020
@tmorehouse tmorehouse requested a review from jacobmllr95 Feb 14, 2020
@jacobmllr95 jacobmllr95 self-requested a review Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Type: Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants