Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v-b-hover): new directive for reacting to hover changes #4771

Merged
merged 48 commits into from Feb 15, 2020
Merged

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 15, 2020

Describe the PR

New directive v-b-hover for reacting to changes in hover on an element

The directive accepts a callback as the value. When the element is hovered or unhovered, the callback is called with a single Boolean argument signifying if the element is hovered (true) or not (false).

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added this to In progress in 2.5.0 via automation Feb 15, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 15, 2020

Codecov Report

Merging #4771 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4771      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         255      256       +1     
  Lines        5285     5292       +7     
  Branches     1405     1405              
==========================================
+ Hits         5281     5288       +7     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/directives/index.js 100% <ø> (ø) ⬆️
src/index.js 100% <ø> (ø) ⬆️
src/directives/hover/hover.js 100% <100%> (ø)
src/directives/hover/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e02769...bcf7e95. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review Feb 15, 2020
@tmorehouse tmorehouse requested a review from jacobmllr95 Feb 15, 2020
@jonalxh
Copy link

@jonalxh jonalxh commented Mar 5, 2021

Maybe it is necessary to receive a second parameter to know which element is being hovered, or there is a way to get it?
In my use case I want to toggle visibility of the content of the hovered card, but I have several cards:

<b-card v-b-hover="toggleCardContent(isHovered, element)">
    <p> lorem... </p>
</b-card>

toggleCardContent(evt, element) {
      const child = element.getElementByTagName("p")
     if (evt) {
         child.style.display = "block"
     } else {
          child.style.display = "none"
    }
}

How to achieve it?

@naletups
Copy link
Contributor

@naletups naletups commented Jul 19, 2021

Same problem here. Is there any convenient way?

For the time being, I just resorted back to @mouseover="omHover(0)" @mouseleave="onUnhover(0)" (replace the parameter with whatever you want)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Minor Type: Feature
Projects
No open projects
2.5.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants