Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-modal): additional fixes for show transition behaviour (closes #4761) #4777

Merged
merged 3 commits into from Feb 17, 2020

Conversation

philipmountifield
Copy link
Contributor

@philipmountifield philipmountifield commented Feb 17, 2020

Describe the PR

Minor adjustments to the modal show transition behaviour

Closes #4761

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 added PR: Patch Requires patch version bump Type: Fix labels Feb 17, 2020
@jacobmllr95 jacobmllr95 added this to In progress in 2.5.0 via automation Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #4777 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4777   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         261      261           
  Lines        5680     5680           
  Branches     1480     1480           
=======================================
  Hits         5676     5676           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dcc0a2...ba56530. Read the comment docs.

@tmorehouse
Copy link
Member

tmorehouse commented Feb 17, 2020

Thanks for the PR!

@tmorehouse tmorehouse changed the title fix(b-modal): inconsistent show transition behaviour (closes #4761) fix(b-modal): additional fixes for show transition behaviour (closes #4761) Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Fix
Projects
No open projects
2.5.0
  
Done
Development

Successfully merging this pull request may close these issues.

"show" class is added to modals too late
3 participants