Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-time, b-form-timepicker): new components b-time and b-form-timepicker #4783

Merged
merged 375 commits into from Mar 3, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 18, 2020

Describe the PR

New components:

  • BTime Time component
  • BFormTimepicker Timepicker form control

To do:

  • create BTime component
  • create BFormTimepicker
  • BTime docs
  • BFormTimepicker docs
  • BTime unit tests
  • BFormTimepicker unit tests
  • create private helper component with common portions of BFormDatepicker and BFormTimepicker
  • use new helper component in BFormDatepicker
  • use new helper component in BFormTimepicker
  • optimize common custom SCSS (using new helper component CSS class name)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) refactor of common code

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added Status: WIP PR: Minor Requires minor version bump labels Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #4783 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4783      +/-   ##
==========================================
+ Coverage   99.93%   99.93%   +<.01%     
==========================================
  Files         263      269       +6     
  Lines        5863     6109     +246     
  Branches     1529     1593      +64     
==========================================
+ Hits         5859     6105     +246     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️
src/components/index.js 100% <ø> (ø) ⬆️
src/components/form-spinbutton/form-spinbutton.js 100% <100%> (ø) ⬆️
src/components/time/index.js 100% <100%> (ø)
src/mixins/dropdown.js 100% <100%> (ø) ⬆️
src/components/form-timepicker/index.js 100% <100%> (ø)
src/utils/bv-form-btn-label-control.js 100% <100%> (ø)
src/components/calendar/calendar.js 100% <100%> (ø) ⬆️
src/components/form-timepicker/form-timepicker.js 100% <100%> (ø)
src/components/time/time.js 100% <100%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165f481...93907f8. Read the comment docs.

@tmorehouse tmorehouse added this to In progress in 2.6.0 via automation Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants