-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date format (closes #4797) #4835
Merged
jacobmllr95
merged 34 commits into
bootstrap-vue:dev
from
naletups:naletups-dateformat-string
Feb 26, 2020
Merged
feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date format (closes #4797) #4835
jacobmllr95
merged 34 commits into
bootstrap-vue:dev
from
naletups:naletups-dateformat-string
Feb 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new prop `formatLong` that defaults to current layout * Allows for better control on display (e.g. in combination with layouts defined in other components like vue-i18n)
Codecov Report
@@ Coverage Diff @@
## dev #4835 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 263 263
Lines 5859 5859
Branches 1528 1528
=======================================
Hits 5855 5855
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
tmorehouse
reviewed
Feb 26, 2020
tmorehouse
reviewed
Feb 26, 2020
tmorehouse
reviewed
Feb 26, 2020
tmorehouse
added
PR: Minor
Requires minor version bump
Status: Changes Needed
Pull request needs changes
Type: Enhancement
Type: Feature
labels
Feb 26, 2020
tmorehouse
changed the title
feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date
feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date format
Feb 26, 2020
tmorehouse
changed the title
feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date format
feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date format (closes #4797)
Feb 26, 2020
tmorehouse
reviewed
Feb 26, 2020
tmorehouse
reviewed
Feb 26, 2020
tmorehouse
approved these changes
Feb 26, 2020
jacobmllr95
approved these changes
Feb 26, 2020
This was referenced Feb 26, 2020
Merged
Closed
This was referenced Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Added prop to allow formatting of in-component displayed date string to allow better control of size (and a better integration with other components defining these format, e.g. vue-i18n). This is especially helpful for space-constrained usage in forms.
Closes #4797
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: