Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date format (closes #4797) #4835

Merged
merged 34 commits into from Feb 26, 2020

Conversation

naletups
Copy link
Contributor

@naletups naletups commented Feb 26, 2020

Describe the PR

Added prop to allow formatting of in-component displayed date string to allow better control of size (and a better integration with other components defining these format, e.g. vue-i18n). This is especially helpful for space-constrained usage in forms.

Closes #4797

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

naletups added 5 commits Feb 26, 2020
* Added new prop `formatLong` that defaults to current layout
* Allows for better control on display (e.g. in combination with layouts defined in other components like vue-i18n)
@codecov
Copy link

@codecov codecov bot commented Feb 26, 2020

Codecov Report

Merging #4835 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4835   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         263      263           
  Lines        5859     5859           
  Branches     1528     1528           
=======================================
  Hits         5855     5855           
  Misses          3        3           
  Partials        1        1
Impacted Files Coverage Δ
src/components/form-datepicker/form-datepicker.js 100% <100%> (ø) ⬆️
src/components/calendar/calendar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98245eb...d65c796. Read the comment docs.

@tmorehouse tmorehouse added PR: Minor Status: Changes Needed Type: Enhancement Type: Feature labels Feb 26, 2020
@tmorehouse tmorehouse added this to In progress in 2.6.0 via automation Feb 26, 2020
@tmorehouse tmorehouse changed the title feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date format Feb 26, 2020
@tmorehouse tmorehouse changed the title feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date format feat(b-calendar, b-form-datepicker): allow customization of in-component displayed date format (closes #4797) Feb 26, 2020
@tmorehouse tmorehouse removed the Status: Changes Needed label Feb 26, 2020
@tmorehouse tmorehouse requested a review from jacobmllr95 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

3 participants