Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-form-spinbutton): prevent double increment/decrement on mobile (fixes #4838) #4842

Merged
merged 6 commits into from Feb 26, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 26, 2020

Describe the PR

Prevent double increment/decrement when clicking +/- buttons on mobile/touch devices

Fixes #4838

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added PR: Patch Status: WIP Type: Fix labels Feb 26, 2020
@tmorehouse tmorehouse added this to In progress in 2.6.0 via automation Feb 26, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 26, 2020

Codecov Report

No coverage uploaded for pull request base (dev@c4b8ea0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #4842   +/-   ##
======================================
  Coverage       ?   99.93%           
======================================
  Files          ?      263           
  Lines          ?     5863           
  Branches       ?     1529           
======================================
  Hits           ?     5859           
  Misses         ?        3           
  Partials       ?        1
Impacted Files Coverage Δ
src/components/form-spinbutton/form-spinbutton.js 100% <100%> (ø)
src/components/form-datepicker/form-datepicker.js 100% <100%> (ø)
src/components/calendar/calendar.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b8ea0...f76860b. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 Feb 26, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Type: Fix
Projects
No open projects
2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

2 participants