Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-calendar, b-for-datepicker): add new initial-date prop, and constrain today/current month buttons between min and max (closes #4899) #4906

Merged
merged 19 commits into from Mar 10, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 7, 2020

Describe the PR

New initial-date prop for setting the initially focused date button (and displayed calendar year/month) when no initial value is provided. If initial-date is not provided, the value defaults to today (constrained between min and max)

The set today button and goto current month buttons will also be constrained to values between min and max)

closes #4899

Preview: https://deploy-preview-4906--bootstrap-vue.netlify.com/

TODO:

  • Add documentation of the prop usage, and the behaviour of the today button (when min/max are used)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

@codecov codecov bot commented Mar 7, 2020

Codecov Report

Merging #4906 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4906      +/-   ##
==========================================
+ Coverage   99.93%   99.93%   +<.01%     
==========================================
  Files         271      271              
  Lines        6137     6140       +3     
  Branches     1602     1602              
==========================================
+ Hits         6133     6136       +3     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/utils/date.js 100% <100%> (ø) ⬆️
src/components/form-datepicker/form-datepicker.js 100% <100%> (ø) ⬆️
src/components/calendar/calendar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134d64d...e7291d6. Read the comment docs.

@tmorehouse tmorehouse changed the title feat(b-calendar, b-for-datepicker): add new initial-date prop, and constrain today/current month between min and max (closes #4899) feat(b-calendar, b-for-datepicker): add new initial-date prop, and constrain today/current month buttons between min and max (closes #4899) Mar 7, 2020
@tmorehouse tmorehouse requested a review from jacobmllr95 Mar 9, 2020
@tmorehouse tmorehouse added the PR: Minor label Mar 9, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Mar 10, 2020
@jacobmllr95 jacobmllr95 merged commit 1d957eb into dev Mar 10, 2020
8 of 9 checks passed
2.7.0 automation moved this from In progress to Done Mar 10, 2020
@jacobmllr95 jacobmllr95 deleted the issue/4899 branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
2.7.0
  
Done
Development

Successfully merging this pull request may close these issues.

2 participants