Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(b-icon): add animated icon options (closes #4720) #4934

merged 57 commits into from Mar 12, 2020


Copy link

tmorehouse commented Mar 12, 2020

Describe the PR

Adds animated icon support.

Closes #4720

To Do:

  • documentation updates (and note on reduced motion media query)
  • add basic unit tests
  • add additional animations via PR #4945

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@tmorehouse tmorehouse added this to In progress in 2.7.0 via automation Mar 12, 2020

This comment has been minimized.

Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #4934 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4934      +/-   ##
+ Coverage   99.93%   99.93%   +<.01%     
  Files         271      271              
  Lines        6145     6146       +1     
  Branches     1604     1604              
+ Hits         6141     6142       +1     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/icons/plugin.js 100% <ø> (ø) ⬆️
src/icons/icons.js 100% <ø> (ø) ⬆️
src/icons/helpers/icon-base.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15f86a...bc7d756. Read the comment docs.

tmorehouse added 20 commits Mar 12, 2020
@tmorehouse tmorehouse requested a review from jackmu95 Mar 12, 2020
@tmorehouse tmorehouse changed the title feature(b-icon): add spinning icon options (closes #4720) feature(b-icon): add animated icon options (closes #4720) Mar 12, 2020
tmorehouse and others added 6 commits Mar 12, 2020
jackmu95 and others added 14 commits Mar 12, 2020
…p-vue into feat/4720
This reverts commit e74bcc4.
…p-vue into feat/4720
This reverts commit 8152bdd.
…p-vue into feat/4720
@jackmu95 jackmu95 removed the Status: WIP label Mar 12, 2020
jackmu95 and others added 2 commits Mar 12, 2020
@tmorehouse tmorehouse merged commit 7c781fa into dev Mar 12, 2020
9 checks passed
9 checks passed
License Compliance All checks passed.
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch 100% of diff hit (target 99.93%)
codecov/project 99.93% (+<.01%) compared to c15f86a
netlify/bootstrap-vue/deploy-preview Deploy preview ready!
security/snyk (pi0) No manifest changes detected
2.7.0 automation moved this from In progress to Done Mar 12, 2020
@tmorehouse tmorehouse deleted the feat/4720 branch Mar 12, 2020
@tmorehouse tmorehouse mentioned this pull request Mar 13, 2020
10 of 20 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.