Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(icons): updates to CSS animations #4945

Merged
merged 22 commits into from Mar 13, 2020
Merged

chore(icons): updates to CSS animations #4945

merged 22 commits into from Mar 13, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 13, 2020

Describe the PR

Additional tweaks to the animations introduced in PR #4934

Allows for stacked icons to individually animate by targeting the first g (child icons only).

Added in cylon-vertical animation, spin-reverse (counter clockwise), and renames pulse to spin-pulse for clarity (and adds spin-reverse-pulse)

Note: IE 11 does not support animating child elements of SVGs. For IE 11, only the b-iconstack can be animated.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added this to In progress in 2.7.0 via automation Mar 13, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 13, 2020

Codecov Report

Merging #4945 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4945   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         271      271           
  Lines        6146     6146           
  Branches     1604     1604           
=======================================
  Hits         6142     6142           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7735729...d8adcf8. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review Mar 13, 2020
@tmorehouse tmorehouse requested a review from jacobmllr95 Mar 13, 2020
@tmorehouse tmorehouse changed the title chore(icons): minor tweaks to CSS animations chore(icons): updates to CSS animations Mar 13, 2020
@tmorehouse tmorehouse added the PR: Patch label Mar 13, 2020
@tmorehouse tmorehouse merged commit b786f67 into dev Mar 13, 2020
9 checks passed
2.7.0 automation moved this from In progress to Done Mar 13, 2020
@tmorehouse tmorehouse deleted the icons-animate-tweak branch Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Type: Enhancement
Projects
No open projects
2.7.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants