Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-form-spinbutton): add slots for increment and decrement button content (closes #4958) #4963

merged 14 commits into from Mar 19, 2020


Copy link

@tmorehouse tmorehouse commented Mar 17, 2020

Describe the PR

Adds (optionally scoped) slots for increment and decrement button content

Closes #4958

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added this to In progress in 2.8.0 via automation Mar 17, 2020
Copy link

@codecov codecov bot commented Mar 17, 2020

Codecov Report

Merging #4963 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4963      +/-   ##
+ Coverage   99.93%   99.93%   +<.01%     
  Files         271      271              
  Lines        6370     6375       +5     
  Branches     1605     1605              
+ Hits         6366     6371       +5     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/form-spinbutton/form-spinbutton.js 100% <100%> (ø) ⬆️
src/components/time/time.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d481365...7a06260. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 Mar 17, 2020
@jacobmllr95 jacobmllr95 marked this pull request as ready for review Mar 18, 2020
@tmorehouse tmorehouse changed the title feat(b-form-spinbutton): add slots for increment and decrement button content feat(b-form-spinbutton): add slots for increment and decrement button content (closes #4958) Mar 19, 2020
@tmorehouse tmorehouse merged commit 5684405 into dev Mar 19, 2020
9 checks passed
2.8.0 automation moved this from In progress to Done Mar 19, 2020
@tmorehouse tmorehouse deleted the issue/4958 branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
PR: Minor Type: Enhancement
No open projects

Successfully merging this pull request may close these issues.

2 participants