Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-avatar): new b-avatar component #4974

Merged
merged 99 commits into from Mar 21, 2020
Merged

feat(b-avatar): new b-avatar component #4974

merged 99 commits into from Mar 21, 2020

Conversation

@tmorehouse
Copy link
Member

tmorehouse commented Mar 20, 2020

Describe the PR

New avatar component

To Do:

  • rename icon-name prop to just icon
  • avatar docs
  • avatar props meta data
  • use BButton when rendering as a button

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@tmorehouse tmorehouse added this to In progress in 2.8.0 via automation Mar 20, 2020
tmorehouse added 5 commits Mar 20, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #4974 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4974      +/-   ##
==========================================
+ Coverage   99.93%   99.93%   +<.01%     
==========================================
  Files         271      273       +2     
  Lines        6375     6409      +34     
  Branches     1605     1615      +10     
==========================================
+ Hits         6371     6405      +34     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/index.js 100% <ø> (ø) ⬆️
src/index.js 100% <ø> (ø) ⬆️
src/components/avatar/avatar.js 100% <100%> (ø)
src/components/avatar/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a4ea5...9fa54d9. Read the comment docs.

tmorehouse added 19 commits Mar 20, 2020
tmorehouse added 8 commits Mar 20, 2020
jackmu95 and others added 7 commits Mar 20, 2020
tmorehouse added 2 commits Mar 21, 2020
@tmorehouse tmorehouse requested a review from jackmu95 Mar 21, 2020
tmorehouse added 5 commits Mar 21, 2020
@jackmu95 jackmu95 merged commit b2325a3 into dev Mar 21, 2020
9 checks passed
9 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.93%)
Details
codecov/project 99.93% (+<.01%) compared to b2a4ea5
Details
netlify/bootstrap-vue/deploy-preview Deploy preview ready!
Details
security/snyk (pi0) No manifest changes detected
Details
2.8.0 automation moved this from In progress to Done Mar 21, 2020
@jackmu95 jackmu95 deleted the feat-avatar branch Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.8.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.