Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(b-overlay): add no-center example #4981

merged 3 commits into from Mar 21, 2020

docs(b-overlay): add no-center example #4981

merged 3 commits into from Mar 21, 2020


Copy link

tmorehouse commented Mar 21, 2020

Describe the PR

Adds an example for usage of the no-center prop.

Added due to a question/comment from twitter

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@tmorehouse tmorehouse added this to In progress in 2.8.0 via automation Mar 21, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Mar 21, 2020
@tmorehouse tmorehouse requested a review from jackmu95 Mar 21, 2020

This comment has been minimized.

Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #4981 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4981   +/-   ##
  Coverage   99.93%   99.93%           
  Files         273      273           
  Lines        6409     6409           
  Branches     1615     1615           
  Hits         6405     6405           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2325a3...4dbc58c. Read the comment docs.

tmorehouse added 2 commits Mar 21, 2020
@tmorehouse tmorehouse changed the title docs(overlay): add no-center example docs(b-overlay): add no-center example Mar 21, 2020
@jackmu95 jackmu95 merged commit 7ce1637 into dev Mar 21, 2020
9 checks passed
9 checks passed
License Compliance All checks passed.
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch Coverage not affected when comparing b2325a3...4dbc58c
codecov/project 99.93% remains the same compared to b2325a3
netlify/bootstrap-vue/deploy-preview Deploy preview ready!
security/snyk (pi0) No manifest changes detected
2.8.0 automation moved this from In progress to Done Mar 21, 2020
@jackmu95 jackmu95 deleted the docs-overlay branch Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.