Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-avatar): add `alt` prop for adding alt attribute to image and icon avatars (closes #4990) #4991

Merged
merged 7 commits into from Mar 23, 2020

Conversation

@tmorehouse
Copy link
Member

tmorehouse commented Mar 23, 2020

Describe the PR

Closes #4990

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
…avatars (closes #4990)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #4991 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4991   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         273      273           
  Lines        6408     6408           
  Branches     1615     1617    +2     
=======================================
  Hits         6404     6404           
  Misses          3        3           
  Partials        1        1
Impacted Files Coverage Δ
src/components/avatar/avatar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 627eaca...7bb0df2. Read the comment docs.

tmorehouse added 2 commits Mar 23, 2020
@tmorehouse tmorehouse changed the title feat(b-avatar): add `img-alt` prop for adding alt attribute to image avatars (closes #4990) feat(b-avatar): add `alt` prop for adding alt attribute to image and icon avatars (closes #4990) Mar 23, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Mar 23, 2020
@tmorehouse tmorehouse removed the Status: WIP label Mar 23, 2020
@tmorehouse tmorehouse added this to To do in 2.9.0 Mar 23, 2020
@tmorehouse tmorehouse moved this from To do to In progress in 2.9.0 Mar 23, 2020
@tmorehouse tmorehouse requested a review from jackmu95 Mar 23, 2020
jackmu95 and others added 2 commits Mar 23, 2020
@jackmu95 jackmu95 merged commit d1474f2 into dev Mar 23, 2020
9 checks passed
9 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.93%)
Details
codecov/project 99.93% (+0%) compared to 627eaca
Details
netlify/bootstrap-vue/deploy-preview Deploy preview ready!
Details
security/snyk (pi0) No manifest changes detected
Details
2.9.0 automation moved this from In progress to Done Mar 23, 2020
@jackmu95 jackmu95 deleted the feat/4990 branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.9.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.