Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): ensure that the IconsPlugin is imported when exporting from playground to CodePen, CodeSandbox, and JsFiddle #5003

Merged
merged 2 commits into from Mar 24, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 24, 2020

Describe the PR

The playground export to CodePen/CodeSandbox/JsFiddle was not installing the icons plugin.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

@codecov codecov bot commented Mar 24, 2020

Codecov Report

Merging #5003 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5003   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         273      273           
  Lines        6403     6403           
  Branches     1617     1617           
=======================================
  Hits         6399     6399           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c0e5a...2e7834f. Read the comment docs.

@tmorehouse tmorehouse added PR: Patch Type: Docs labels Mar 24, 2020
@tmorehouse tmorehouse changed the title docs(play): ensure that the Icons plugin is imported when exporting: fix(docs): ensure that the Icons plugin is imported when exporting from playground: Mar 24, 2020
@tmorehouse tmorehouse changed the title fix(docs): ensure that the Icons plugin is imported when exporting from playground: fix(docs): ensure that the Icons plugin is imported when exporting from playground Mar 24, 2020
@tmorehouse tmorehouse changed the title fix(docs): ensure that the Icons plugin is imported when exporting from playground fix(docs): ensure that the IconsPlugin is imported when exporting from playground to CodePen, CodeSaandbox, and JsFiddle Mar 24, 2020
@tmorehouse tmorehouse changed the title fix(docs): ensure that the IconsPlugin is imported when exporting from playground to CodePen, CodeSaandbox, and JsFiddle fix(docs): ensure that the IconsPlugin is imported when exporting from playground to CodePen, CodeSandbox, and JsFiddle Mar 24, 2020
@tmorehouse tmorehouse added this to In progress in 2.9.0 via automation Mar 24, 2020
@jacobmllr95 jacobmllr95 self-requested a review Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Type: Docs Type: Fix
Projects
No open projects
2.9.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants