Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-aspect): new custom component <b-aspect> #5008

Merged
merged 34 commits into from Mar 25, 2020
Merged

feat(b-aspect): new custom component <b-aspect> #5008

merged 34 commits into from Mar 25, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 25, 2020

Describe the PR

New component <b-aspect> for maintaining arbitrary aspect ratios for content.

Would be handy for content inside of <b-carousel-slide> (via the img slot), and other uses where the shape of content should remain the same.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added this to In progress in 2.9.0 via automation Mar 25, 2020
@tmorehouse tmorehouse added the PR: Minor label Mar 25, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 25, 2020

Codecov Report

Merging #5008 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5008   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         275      275           
  Lines        6423     6423           
  Branches     1620     1620           
=======================================
  Hits         6419     6419           
  Misses          3        3           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794f603...794f603. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review Mar 25, 2020
@tmorehouse tmorehouse requested a review from jacobmllr95 Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.9.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants