-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-drodpown-item-button, b-drodpown-item-button): add button-class
and link-class
prop
#5014
feat(b-drodpown-item-button, b-drodpown-item-button): add button-class
and link-class
prop
#5014
Conversation
Add the button class prop to the b-dropdown-item-button and also add a test to ensure its working as expected.
Codecov Report
@@ Coverage Diff @@
## dev #5014 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 275 275
Lines 6423 6423
Branches 1620 1620
=======================================
Hits 6419 6419
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
@tmorehouse does this seem like a prop that would be okay to add? Wanted to get your opinion before I move onto finishing the rest of the checklist. 🙇 |
button-class
and link-class
prop
@beardedpayton just made a few tweaks, and updated the package.json component meta data to indicate the version the prop was added, as well as description for it. And added a similar prop for |
Add new test to ensure the linkClass prop value is applied correctly to the a element.
@tmorehouse thanks! I just added a test for the Does this PR need anymore attention? |
I think it is good as is now 👍 |
Thanks @pburdette! |
Thanks @jackmu95 and @tmorehouse 🎉 |
@pburdette BootstrapVue v2.9.0 has been released. |
Describe the PR
Reason for this PR: It would be nice to use utility classes on this button without having to introduce new CSS into a codebase.
button-class
prop to theb-dropdown-item-button
component.link-class
prop to theb-dropdown-item
component.dropdown-item-button.spec.js
with a new testdropdown-item.spec.js
with a new testPR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: