Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-table): fix context object issue introduced in v2.10.0 (fixes #5065) #5067

Merged
merged 2 commits into from Apr 2, 2020

Conversation

noobling
Copy link
Contributor

@noobling noobling commented Apr 2, 2020

Describe the PR

Closes #5065.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #5067 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5067   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         277      277           
  Lines        6494     6494           
  Branches     1607     1607           
=======================================
  Hits         6490     6490           
  Misses          3        3           
  Partials        1        1           
Impacted Files Coverage Δ
src/components/table/helpers/mixin-items.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcda1b7...980a52a. Read the comment docs.

@jacobmllr95 jacobmllr95 changed the title fix(table): fix bad copy paste by using correct value fix(table): fix currentPage value in slot context (closes #5065) Apr 2, 2020
@jacobmllr95 jacobmllr95 added PR: Patch Requires patch version bump Type: Fix labels Apr 2, 2020
@jacobmllr95 jacobmllr95 merged commit 874dca2 into bootstrap-vue:dev Apr 2, 2020
8 checks passed
@jacobmllr95
Copy link
Member

jacobmllr95 commented Apr 2, 2020

Thanks @noobling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Fix
Projects
No open projects
2.11.0
  
Done
Development

Successfully merging this pull request may close these issues.

2 participants