Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip/popover): handle click blur on iOS webkit browsers (fixes #5099) #5103

Merged
merged 2 commits into from Apr 6, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 5, 2020

Describe the PR

Ensures that the trigger element gains focus when clicked.

iOS webkit does not focus an element when it is clicked (touched) (https://bugs.webkit.org/show_bug.cgi?id=22261)

Fixes #5099

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #5103 into dev will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5103   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         277      277           
  Lines        6494     6496    +2     
  Branches     1607     1607           
=======================================
+ Hits         6490     6492    +2     
  Misses          3        3           
  Partials        1        1           
Impacted Files Coverage Δ
src/components/tooltip/helpers/bv-tooltip.js 99.60% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d2671...d6e542e. Read the comment docs.

@tmorehouse tmorehouse added the PR: Patch label Apr 5, 2020
@tmorehouse tmorehouse requested a review from jacobmllr95 Apr 5, 2020
@tmorehouse tmorehouse added this to In progress in 2.11.0 via automation Apr 5, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Apr 6, 2020
@jacobmllr95 jacobmllr95 merged commit 27da76c into dev Apr 6, 2020
8 of 9 checks passed
2.11.0 automation moved this from In progress to Done Apr 6, 2020
@jacobmllr95 jacobmllr95 deleted the issue-5099 branch Apr 6, 2020
@tmorehouse tmorehouse changed the title fi(tooltip/popover): handle click blur on iOS webkit browsers (fixes #5099) fix(tooltip/popover): handle click blur on iOS webkit browsers (fixes #5099) Apr 6, 2020
@tmorehouse tmorehouse mentioned this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
2.11.0
  
Done
Development

Successfully merging this pull request may close these issues.

3 participants