Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): new throb and fade animations #5122

Merged
merged 24 commits into from Apr 13, 2020
Merged

feat(icons): new throb and fade animations #5122

merged 24 commits into from Apr 13, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 9, 2020

Describe the PR

Adds a new icon animations throb (varies scale and opacity) and fade (varies opacity)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) SCSS updates

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

@codecov codecov bot commented Apr 9, 2020

Codecov Report

Merging #5122 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          277       277           
  Lines         6537      6537           
  Branches      1617      1617           
=========================================
  Hits          6537      6537           
Impacted Files Coverage Δ
src/icons/icons.js 100.00% <ø> (ø)
src/icons/plugin.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d504f...fdb251b. Read the comment docs.

@tmorehouse tmorehouse changed the title feat(icons): new throb animation feat(icons): new throb and fade animations Apr 9, 2020
@tmorehouse tmorehouse added this to In progress in v2.12.0 Apr 9, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Apr 9, 2020
@tmorehouse tmorehouse requested a review from jacobmllr95 Apr 9, 2020
@tmorehouse tmorehouse added Type: SCSS PR: Minor labels Apr 9, 2020
@tmorehouse tmorehouse merged commit bc0117c into dev Apr 13, 2020
9 checks passed
v2.12.0 automation moved this from In progress to Done Apr 13, 2020
@tmorehouse tmorehouse deleted the icons-amination branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v2.12.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants