Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-form-datepicker): make datepicker respect no-highlight-today prop #5159

merged 1 commit into from Apr 16, 2020


Copy link

@michaelathatch michaelathatch commented Apr 16, 2020

Describe the PR

no-highlight-today prop was not being passed to b-calendar, so it wasn't being set.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

`no-highlight-today` prop was not being passed to `b-calendar`, so it wasn't being set.
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #5159 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5159   +/-   ##
  Coverage   100.00%   100.00%           
  Files          279       279           
  Lines         8672      8672           
  Branches      2480      2480           
  Hits          8672      8672           
Flag Coverage Δ
#unittests 100.00% <ø> (ø)
Impacted Files Coverage Δ
src/components/form-datepicker/form-datepicker.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7f33d...e40c0da. Read the comment docs.

@tmorehouse tmorehouse added PR: Patch Type: Fix labels Apr 16, 2020
@tmorehouse tmorehouse added this to In progress in v2.12.0 via automation Apr 16, 2020
Copy link

tmorehouse commented Apr 16, 2020

Thanks! 👍

@tmorehouse tmorehouse changed the title fix(b-form-datepicker): Make datepicker respect no-highlight-today. fix(b-form-datepicker): make datepicker respect no-highlight-today prop Apr 16, 2020
@tmorehouse tmorehouse merged commit c4ead33 into bootstrap-vue:dev Apr 16, 2020
12 checks passed
v2.12.0 automation moved this from In progress to Done Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
PR: Patch Type: Fix
No open projects

Successfully merging this pull request may close these issues.

None yet

2 participants