Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-form-rating): add show-value-max prop to show possible max rating when show-value is true #5200

Merged
merged 14 commits into from Apr 21, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 21, 2020

Describe the PR

When show-value is true, optionally show the x/stars rating value when new prop show-value-max is true

To Do:

  • meta data update
  • documentation update

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added this to In progress in v2.13.0 via automation Apr 21, 2020
@vercel
Copy link

@vercel vercel bot commented Apr 21, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/bootstrap-vue/bootstrap-vue/b7mt5uyxa
Preview: https://bootstrap-vue-git-feat-rating-max-value.bootstrap-vue.now.sh

@vercel vercel bot temporarily deployed to Preview Apr 21, 2020 Inactive
@vercel vercel bot temporarily deployed to Preview Apr 21, 2020 Inactive
@vercel vercel bot temporarily deployed to Preview Apr 21, 2020 Inactive
@codecov
Copy link

@codecov codecov bot commented Apr 21, 2020

Codecov Report

Merging #5200 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5200   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          279       279           
  Lines         8697      8704    +7     
  Branches      2486      2489    +3     
=========================================
+ Hits          8697      8704    +7     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/components/form-rating/form-rating.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df560b...280d1d6. Read the comment docs.

@tmorehouse tmorehouse requested a review from jacobmllr95 Apr 21, 2020
@jacobmllr95 jacobmllr95 marked this pull request as ready for review Apr 21, 2020
@vercel vercel bot temporarily deployed to Preview Apr 21, 2020 Inactive
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 280d1d6:

Sandbox Source
angry-neumann-czvmg Configuration

@tmorehouse tmorehouse changed the title feat(b-form-rating): add show-max-value prop to show possible max rating when show-value is true feat(b-form-rating): add show-value-max prop to show possible max rating when show-value is true Apr 21, 2020
@jacobmllr95 jacobmllr95 merged commit e9d54e6 into dev Apr 21, 2020
13 of 14 checks passed
v2.13.0 automation moved this from In progress to Done Apr 21, 2020
@jacobmllr95 jacobmllr95 deleted the feat-rating-max-value branch Apr 21, 2020
@tmorehouse tmorehouse mentioned this pull request Apr 22, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Minor Type: Enhancement
Projects
No open projects
v2.13.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants