Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-form-datepicker, b-form-timepicker): adjust scss to support input-groups #5231

Merged
merged 6 commits into from Apr 23, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 23, 2020

Describe the PR

Additional custom SCSS to allow b-form-datepicker and b-form-time-picker (non button mode) to be placed as main input in input groups. Button mode already works well with input groups.

It is not quite perfect for sm input-groups as the input-group ends up being 2px taller than normal small input groups.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe) SCSS

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

@vercel vercel bot commented Apr 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/gqhok3xty
Preview: https://bootstrap-vue-git-date-time-input-group.bootstrap-vue.now.sh

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8570aa3:

Sandbox Source
relaxed-ptolemy-jb286 Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 23, 2020

Codecov Report

Merging #5231 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          279       279           
  Lines         8704      8704           
  Branches      2489      2489           
=========================================
  Hits          8704      8704           
Flag Coverage Δ
#unittests 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6354e6e...8570aa3. Read the comment docs.

@tmorehouse
Copy link
Member Author

@tmorehouse tmorehouse commented Apr 23, 2020

To be merged after #5238 (and a few minor updates to this PR)

@tmorehouse tmorehouse marked this pull request as ready for review Apr 23, 2020
@tmorehouse tmorehouse mentioned this pull request Apr 23, 2020
9 tasks
@tmorehouse tmorehouse merged commit 7b1adc4 into dev Apr 23, 2020
14 checks passed
@tmorehouse tmorehouse deleted the date-time-input-group branch Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants