-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-form-datepicker, b-form-timepicker): adjust scss to support input-groups #5231
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/gqhok3xty |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8570aa3:
|
Codecov Report
@@ Coverage Diff @@
## dev #5231 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 279 279
Lines 8704 8704
Branches 2489 2489
=========================================
Hits 8704 8704
Continue to review full report at Codecov.
|
To be merged after #5238 (and a few minor updates to this PR) |
Describe the PR
Additional custom SCSS to allow b-form-datepicker and b-form-time-picker (non button mode) to be placed as main input in input groups. Button mode already works well with input groups.
It is not quite perfect for sm input-groups as the input-group ends up being 2px taller than normal small input groups.PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: