feat(b-overlay): add support for overlay click event (closes #5243)
#5248
Conversation
|
This pull request is being automatically deployed with Vercel (learn more).
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 492c154:
|
Codecov Report
@@ Coverage Diff @@
## dev #5248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 279 279
Lines 8706 8707 +1
Branches 2489 2489
=========================================
+ Hits 8706 8707 +1
Continue to review full report at Codecov.
|
| @@ -146,7 +146,8 @@ export const BOverlay = /*#__PURE__*/ Vue.extend({ | |||
| 'position-absolute': !this.noWrap || (this.noWrap && !this.fixed), | |||
| 'position-fixed': this.noWrap && this.fixed | |||
| }, | |||
| style: { ...positionCover, zIndex: this.zIndex || 10 } | |||
| style: { ...positionCover, zIndex: this.zIndex || 10 }, | |||
| on: { click: evt => this.$emit('click', evt) } | |||
There was a problem hiding this comment.
Maybe this should be overlay-click?
There was a problem hiding this comment.
thought about that too but I think it is fine like that.
There was a problem hiding this comment.
Vue 3 is going to make it difficult to use custom events names that are the same as native event names (they got rid of the .native modifier)
There was a problem hiding this comment.
as all future events (Vue v3) will be added by onClick="handler" (i.e. as $attrs) where there is no option to bind a native listener (if users want to) to the root element
tmorehouse
changed the title
click event (closes #5243)click event (closes #5243)
tmorehouse
changed the title
click event (closes #5243)click event (closes #5243)
Describe the PR
This PR adds support for the
clickevent on the<b-overlay>component's overlay.PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: