Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-link): default new <nuxt-link> prop prefetch to null for true tri-state prop #5357

Merged
merged 14 commits into from May 12, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented May 12, 2020

Describe the PR

Vue coerces Boolean props to be false when the default is undefined.

This tweaks the BLink prop to default to null, and coerces it to undefined when passing it to <nuxt-link>

Also adds the "version" property to the common props meta json file.

This is an augment to PR #5355

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercel bot commented May 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/n3z6996f5
Preview: https://bootstrap-vue-git-nuxtlink-fix.bootstrap-vue.now.sh

@tmorehouse tmorehouse requested a review from jacobmllr95 May 12, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e919f95:

Sandbox Source
smoosh-cookies-er9op Configuration

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #5357 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          281       281           
  Lines         8830      8833    +3     
  Branches      2505      2507    +2     
=========================================
+ Hits          8830      8833    +3     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/components/breadcrumb/breadcrumb-link.js 100.00% <ø> (ø)
src/components/badge/badge.js 100.00% <100.00%> (ø)
src/components/button/button.js 100.00% <100.00%> (ø)
src/components/dropdown/dropdown-item.js 100.00% <100.00%> (ø)
src/components/link/link.js 100.00% <100.00%> (ø)
src/components/list-group/list-group-item.js 100.00% <100.00%> (ø)
src/components/nav/nav-item.js 100.00% <100.00%> (ø)
src/components/navbar/navbar-brand.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 101faab...e919f95. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review May 12, 2020
@tmorehouse tmorehouse added the PR: Patch label May 12, 2020
@tmorehouse tmorehouse changed the title chore(b-link): set prefetch to null fix(b-link): default nuxt-link prefetch to null for true tri-state prop May 12, 2020
@tmorehouse tmorehouse added this to In progress in v2.15.0 via automation May 12, 2020
@tmorehouse tmorehouse changed the title fix(b-link): default nuxt-link prefetch to null for true tri-state prop fix(b-link): default new <nuxt-link> prop prefetch to null for true tri-state prop May 12, 2020
src/components/button/button.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview May 12, 2020 Inactive
src/components/button/button.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview May 12, 2020 Inactive
@tmorehouse tmorehouse merged commit 3f41c91 into dev May 12, 2020
14 checks passed
v2.15.0 automation moved this from In progress to Done May 12, 2020
@tmorehouse tmorehouse deleted the nuxtlink-fix branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Type: Fix
Projects
No open projects
v2.15.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants