Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-skeleton): add skeleton components (closes #5413) #5575

merged 47 commits into from Aug 21, 2020


Copy link

@Hiws Hiws commented Jul 13, 2020

Describe the PR

Introduces a skeleton-loader components + sub-components to help users create a loading state for their page, with similar scaffolding.

Inspiration is taken from Vuetify and Quasar.


  • Create loaders to cover existing components
  • Write sufficient documentation on the new components
  • Check AIRA support
  • Write tests
  • Add types to index.d.ts

Closes #5413

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

Copy link

codesandbox-ci bot commented Jul 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0df9a28:

Sandbox Source
BootstrapVue Starter Project Configuration

Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #5575 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5575   +/-   ##
  Coverage   100.00%   100.00%           
  Files          278       284    +6     
  Lines         9412      9461   +49     
  Branches      2512      2521    +9     
+ Hits          9412      9461   +49     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/index.js 100.00% <ø> (ø)
src/index.js 100.00% <ø> (ø)
src/components/skeleton/index.js 100.00% <100.00%> (ø)
src/components/skeleton/skeleton-icon.js 100.00% <100.00%> (ø)
src/components/skeleton/skeleton-img.js 100.00% <100.00%> (ø)
src/components/skeleton/skeleton-table.js 100.00% <100.00%> (ø)
src/components/skeleton/skeleton-wrapper.js 100.00% <100.00%> (ø)
src/components/skeleton/skeleton.js 100.00% <100.00%> (ø)
src/utils/array.js 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43806dc...0df9a28. Read the comment docs.

Copy link

vercel bot commented Jul 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:

@jacobmllr95 jacobmllr95 added this to In progress in v2.16.0 via automation Jul 13, 2020
@jacobmllr95 jacobmllr95 added this to In progress in v2.17.0 via automation Jul 21, 2020
@jacobmllr95 jacobmllr95 removed this from In progress in v2.16.0 Jul 21, 2020
@vercel vercel bot temporarily deployed to Preview August 19, 2020 15:31 Inactive
@vercel vercel bot temporarily deployed to Preview August 19, 2020 15:33 Inactive
@vercel vercel bot temporarily deployed to Preview August 19, 2020 15:34 Inactive
@vercel vercel bot temporarily deployed to Preview August 19, 2020 15:36 Inactive
@Hiws Hiws removed the Status: WIP label Aug 20, 2020
@jacobmllr95 jacobmllr95 changed the title feat(b-skeleton): Add skeleton components (closes #5413) feat(b-skeleton): add skeleton components (closes #5413) Aug 21, 2020
@vercel vercel bot temporarily deployed to Preview August 21, 2020 05:54 Inactive
@jacobmllr95 jacobmllr95 merged commit 31c06b5 into bootstrap-vue:dev Aug 21, 2020
6 checks passed
v2.17.0 automation moved this from In progress to Done Aug 21, 2020
@Hiws Hiws deleted the b-skeleton-component branch March 25, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No open projects

Successfully merging this pull request may close these issues.

b-skeleton-loader component
2 participants