Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-calendar): add nav-button-variant prop (closes #5702) #5705



Copy link

@Hiws Hiws commented Aug 27, 2020

Describe the PR

This PR adds a nav-button-variant prop to <b-calendar> and <b-form-datepicker>, to control the variant.
It defaults to secondary, and is configurable via <b-calendar> and <b-form-datepicker> settings.

The PR also adds support for the selected-variant and today-variant props to be configurable via settings.

Closes #5702.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

@Hiws Hiws added Type: Enhancement PR: Minor Requires minor version bump labels Aug 27, 2020
@Hiws Hiws requested a review from jacobmllr95 August 27, 2020 10:45
Copy link

vercel bot commented Aug 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:

Copy link

codesandbox-ci bot commented Aug 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 67a7b99:

Sandbox Source
BootstrapVue Starter Project Configuration

Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #5705 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5705   +/-   ##
  Coverage   100.00%   100.00%           
  Files          284       284           
  Lines         9547      9548    +1     
  Branches      2520      2520           
+ Hits          9547      9548    +1     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/calendar/calendar.js 100.00% <ø> (ø)
src/components/form-datepicker/form-datepicker.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc2d35...67a7b99. Read the comment docs.

@jacobmllr95 jacobmllr95 changed the title feat(b-calendar): Add nav-button-variant prop (closes #5702) feat(b-calendar): add nav-button-variant prop (closes #5702) Sep 1, 2020
@jacobmllr95 jacobmllr95 merged commit aa291fc into bootstrap-vue:dev Sep 1, 2020
2 of 3 checks passed
@Hiws Hiws deleted the BCalendar-add-nav-button-variant-prop branch March 25, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
PR: Minor Requires minor version bump Type: Enhancement
None yet

Successfully merging this pull request may close these issues.

allow calendar navigation button variant styling
2 participants