Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-icon): add proper title support (closes #5711) #5724

merged 8 commits into from Sep 3, 2020


Copy link

@Hiws Hiws commented Sep 3, 2020

Describe the PR

This PR fixes the handling if the title attribute is used on <b-icon> or <b-iconstack>. Instead of adding a title attribute, it will create a <title> element inside the <svg>.

Closes #5711

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

@Hiws Hiws requested a review from jacobmllr95 Sep 3, 2020
@jacobmllr95 jacobmllr95 added this to In progress in v2.17.0 via automation Sep 3, 2020
Copy link

codesandbox-ci bot commented Sep 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 100999c:

Sandbox Source
BootstrapVue Starter Project Configuration

Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #5724 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5724   +/-   ##
  Coverage   100.00%   100.00%           
  Files          284       284           
  Lines         9552      9554    +2     
  Branches      2522      2523    +1     
+ Hits          9552      9554    +2     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/icons/icons.js 100.00% <ø> (ø)
src/icons/plugin.js 100.00% <ø> (ø)
src/icons/helpers/icon-base.js 100.00% <100.00%> (ø)
src/icons/helpers/make-icon.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a892f0...100999c. Read the comment docs.

Copy link

vercel bot commented Sep 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:

@jacobmllr95 jacobmllr95 changed the title fix(b-icon): add proper title support (closes #5711) feat(b-icon): add proper title support (closes #5711) Sep 3, 2020
src/icons/helpers/icon-base.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview Sep 3, 2020 Inactive
@jacobmllr95 jacobmllr95 merged commit 3756b2c into bootstrap-vue:dev Sep 3, 2020
3 checks passed
v2.17.0 automation moved this from In progress to Done Sep 3, 2020
@Hiws Hiws deleted the b-icon-add-title-support branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No open projects

Successfully merging this pull request may close these issues.

b-icon title support
2 participants