Repository navigation
fix: component destroy handling on parent destroy (closes #5747) - #5749
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/8t7o8gzgf |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d670886:
|
Codecov Report
@@ Coverage Diff @@
## dev #5749 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 284 284
Lines 9564 9569 +5
Branches 2525 2525
=========================================
+ Hits 9564 9569 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@Charlie50503 @Hiws |
Describe the PR
This PR fixes the
v-b-popover/v-b-tooltipdestroy behavior when the parent gets destroyed.While at it, this PR unifies the logic to do so for all components that need to destroy itself on parent destroy.
Closes #5747.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: