New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove usage of es2015 Array.prototype.includes #589

Merged
merged 29 commits into from Jun 30, 2017

Conversation

Projects
None yet
3 participants
@alexsasharegan
Contributor

alexsasharegan commented Jun 30, 2017

Resolves issue #587

Alex Regan added some commits Apr 29, 2017

Alex Regan
Alex Regan
Merge branch 'master' of https://github.com/bootstrap-vue/bootstrap-vue
# Conflicts:
#	lib/components/form-fieldset.vue
Alex Regan
Alex Regan
Merge branch 'master' of https://github.com/bootstrap-vue/bootstrap-vue
# Conflicts:
#	lib/components/form-input.vue
Alex Regan

@alexsasharegan alexsasharegan requested a review from pi0 Jun 30, 2017

@tmorehouse tmorehouse added this to the v0.17.2 milestone Jun 30, 2017

@tmorehouse

👍

@tmorehouse tmorehouse merged commit b3fc095 into bootstrap-vue:master Jun 30, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jun 30, 2017

Darn es2015 is part of my regular language already!

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

Heheh.

@mosinve

This comment has been minimized.

Member

mosinve commented Jun 30, 2017

maybe better to use polyfill suggested at MDN?
https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/Array/includes
IMHO, this will add more compability at future...

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jun 30, 2017

We don't currently have a place for polyfills to be injected, otherwise I'm a polyfill first kind of guy.

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jun 30, 2017

And, unfortunately, they can be larger than just using utility methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment