New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): use listenOnRoot mixin #593

Merged
merged 2 commits into from Jun 30, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Jun 30, 2017

Uses new listenOnRoot mixin by @alexsasharegan to ensure $root event listeners are removed on destroy

@tmorehouse tmorehouse requested a review from alexsasharegan Jun 30, 2017

@tmorehouse tmorehouse added this to the v0.17.2 milestone Jun 30, 2017

@tmorehouse tmorehouse changed the title from [modal] use listenOnRoot mixin to fix(modal): use listenOnRoot mixin Jun 30, 2017

@alexsasharegan

Is it worth pulling out to a method?

@tmorehouse tmorehouse referenced this pull request Jun 30, 2017

Closed

collapse::toggle::state triggered too many times #569

2 of 2 tasks complete
@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

the callbacks? I was thinking about that. just needed a name for them

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

moved the handlers into methods.

@alexsasharegan

Lovely!

@tmorehouse tmorehouse merged commit 531a6ab into master Jun 30, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-modal-listen branch Jun 30, 2017

@tmorehouse tmorehouse modified the milestones: v0.18.0, v0.17.2 Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment